Re: [PATCH v2 net 0/4] ENETC GSO fixes

From: Eric Dumazet

Date: Thu Nov 19 2026 - 04:42:20 EST


Le jeu. 19 nov. 2026 à 00:51, Vladimir Oltean
<vladimir.oltean@xxxxxxx> a écrit :
>
> Sashiko derailed me from "[PATCH v5 net 0/4] Fix short frame
> transmission in enetc":
> https://lore.kernel.org/netdev/20261021145314.1435049-1-vladimir.oltean@xxxxxxx/
>
> which also touches the driver GSO code path, so I'm making a detour
> to fix 3 unrelated issues there (which I could all reproduce using
> LLM-produced programs).
>
> The main highlight of this series is the introduction of
> .ndo_features_check() for enetc, which runs for every transmitted skb.
> Each patch makes its implementation more and more complex (and I'm not
> done...).
>
> These patches all assume that at .ndo_features_check() time,
> skb_shinfo(skb)->gso_segs is set properly. There might be issues there,
> see commit 67b0cca9ba88 ("net: validate xmit skbs in generic_xdp_tx()")
> which fixes one case which led to gso_segs reaching the driver while
> being zero. For some reason it was merged to net-next though.
>
> Running a bidirectional eno0 <-> swp0 forwarding of raw IPv4 64B packets
> (no GRO or GSO) on LS1028A-QDS rather than some micro-benchmark,
> I am not seeing a noticeable performance degradation. It is in the
> noise margin.
> Before: 7440 Kpps ingress, 586 Kpps egress
> After: 7440 Kpps ingress, 588 Kpps egress

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks.