Re: [PATCH net v4 0/2] tcp: initialize missing request_sock fields in syncookie path
From: Eric Dumazet
Date: Thu Nov 19 2026 - 03:48:33 EST
Le mer. 18 nov. 2026 à 22:09, Thaison Phan <thaisonphan@xxxxxxxxxx> a écrit :
>
> Initialize missing request_sock fields for TCP connections accepted via
> SYN cookies, where cookie_tcp_reqsk_alloc() and
> bpf_sk_assign_tcp_reqsk() allocate without __GFP_ZERO:
>
> - Patch 1 initializes ireq->ir_rmt_addr and ireq->ir_loc_addr to
> LOOPBACK4_IPV6 in cookie_v6_check(), matching tcp_v6_init_req().
> - Patch 2 initializes the AccECN request_sock fields in
> cookie_tcp_reqsk_init() and sets syn_ect_snt in cookie_{v4,v6}_check()
> for kernel-generated cookies (!req->syncookie), matching
> tcp_openreq_init() and tcp_{v4,v6}_send_synack().
>
> An AI coding assistant helped audit the request_sock initialization
> paths, write the QEMU reproducer, and draft the changelogs.
>
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> v4:
> - Patch 2: restore treq->syn_ect_snt = 0 in cookie_tcp_reqsk_init()
> and guard syn_ect_snt updates in cookie_{v4,v6}_check() with
> !req->syncookie for BPF custom syncookies; document in changelog
> (Sashiko, Eric Dumazet)
> - Patch 2: add Reviewed-by tag from Matthieu Baerts
> v3: https://lore.kernel.org/netdev/20261117124710.1338951-1-thaisonphan@xxxxxxxxxx/
> - Patch 2: clarify syn_ect_snt / tcp_accecn_third_ack() description
> for AccECN connections and reference RFC 9768 Table 4
> (Chia-Yu Chang)
> v2: https://lore.kernel.org/netdev/20261116023709.132684-1-thaisonphan@xxxxxxxxxx/
> - Patch 1: clarify how KASAN (via SLUB_RCU_DEBUG) exposed the bug,
> explain how it was observed, and include the inet_sock_set_state
> trace line (Eric Dumazet)
> - Patch 2: drop redundant treq->syn_ect_snt = 0 in
> cookie_tcp_reqsk_init() and clarify how the bug was found and
> observed via TCP_INFO (Eric Dumazet)
> - Add Eric Dumazet's Reviewed-by tags
> v1: https://lore.kernel.org/netdev/20261114161248.3428695-1-thaisonphan@xxxxxxxxxx/
>
> Thaison Phan (2):
> tcp: initialize ir_rmt_addr and ir_loc_addr in cookie_v6_check()
> tcp: accecn: initialize AccECN fields in syncookie path
>
> net/ipv4/syncookies.c | 7 +++++++
> net/ipv6/syncookies.c | 6 ++++++
> 2 files changed, 13 insertions(+)
>
>
> base-commit: 2a324a58a084c5cfd7e5a2f55e0786bee170a4a5
> --
> 2.56.1.831.g720f3f5937-goog
>