RE: [PATCH rtw-next v8 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames
From: Ping-Ke Shih
Date: Thu Nov 19 2026 - 03:09:55 EST
Enver Ikromov <owner@xxxxxxxxxxxxxx> wrote:
> Injected management frames currently overwrite caller-supplied sequence
> numbers because hardware sequence numbering remains enabled when
> IEEE80211_TX_CTL_ASSIGN_SEQ is unset, and injected frames ignore NO_ACK
> and explicit radiotap retry limits.
>
> Preserve the caller's sequence number when IEEE80211_TX_CTL_ASSIGN_SEQ
> is not set, honor radiotap retry counts up to RTW89_TX_DATA_CNT_LMT_MAX
> (63), and report IEEE80211_TX_STAT_NOACK_TRANSMITTED for NO_ACK frames.
> Set BE_TXD_BODY6_NO_ACK on Wi-Fi 7 chips that carry NO_ACK in the TX
> descriptor;
I'd add "(not tested)" here.
No need v9 because of this.
> Wi-Fi 6 chips such as RTL8852AE do not have a TX descriptor
> NO_ACK field and only limit transmission to a single attempt via
> tx_cnt_lmt = 1.
>
> Signed-off-by: Enver Ikromov <owner@xxxxxxxxxxxxxx>
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>