Re: [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th

From: Zhang Heng

Date: Thu Nov 19 2026 - 02:45:11 EST


Hi Jeremy,

Thank you for the report and for the precise diagnosis. You are right,
and I'm sorry for the regression -- I introduced it with commit
108704eecab9.

The cause was my oversight of the vendor-level fallback. In
alc269_fixup_vendor_tbl[] there is a catch-all entry:

SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo XPAD",
ALC269_FIXUP_LENOVO_XPAD_ACPI)

It chains to ALC269_FIXUP_THINKPAD_ACPI, which at
HDA_FIXUP_ACT_PRE_PROBE calls snd_hda_gen_add_mute_led_cdev() and
snd_hda_gen_add_micmute_led_cdev(). Before my commit, 17aa:225c had no
specific entry in alc269_fixup_tbl[], so it fell through to this fallback
and the LEDs were registered. Adding the specific quirk made
snd_hda_pick_fixup() return early with fixup_id already set, so the
vendor fallback was never consulted. ALC285_LENOVO_DAC_RENAME had no
chain, and the LED registration was silently dropped.

Your proposed fix is correct. In sound/hda/codecs/realtek/alc269.c, add
two fields to the ALC285_LENOVO_DAC_RENAME fixup definition:

.chained = true,
.chain_id = ALC269_FIXUP_THINKPAD_ACPI,

Keep the rename in alc285_lenovo_dac_rename() at HDA_FIXUP_ACT_BUILD.
The two actions run in different fixup phases, and THINKPAD_ACPI chains
to ALC269_FIXUP_SKU_IGNORE with no cycle.

Since you already found the root cause and have a machine to verify on,
would you like to submit the patch yourself?

If you'd rather not, just say so and I'll submit the fix myself -- no
need to explain. Either way, please include a Fixes: tag pointing to
108704eecab9. If you send it, use your own Signed-off-by and I'll add my
Reviewed-by on the list.

Thanks again for the excellent report.

Regards,
Zhang Heng