[PATCH net v2] bonding: reject a non-Ethernet 802.3ad slave even when the type matches
From: Kyuwon Cho
Date: Wed Nov 18 2026 - 22:31:25 EST
Commit c84fcb79e5db ("bonding: limit BOND_MODE_8023AD to Ethernet
devices") rejects a non-Ethernet first slave in 802.3ad mode, but only
when enslaving it changes the bond's type. A bond keeps the type of its
last slave after that slave is released, so a bond that once had an
ARPHRD_TUNNEL6 slave can be set to 802.3ad and take another TUNNEL6
device, such as a second bond prepared the same way, without the check.
bond_open() then adds the 8-byte lacpdu_mcast_addr to that slave with
dev_mc_add(), which copies the slave's 16-byte addr_len:
BUG: KASAN: global-out-of-bounds in __hw_addr_add_ex (net/core/dev_addr_lists.c:102 net/core/dev_addr_lists.c:157)
Read of size 16 at addr ffffffff878a2940 by task test/114
Call Trace:
<TASK>
__hw_addr_add_ex (net/core/dev_addr_lists.c:102 net/core/dev_addr_lists.c:157)
dev_mc_add (net/core/dev_addr_lists.c:1036 net/core/dev_addr_lists.c:1054)
bond_open (drivers/net/bonding/bond_main.c:4405)
__dev_open (net/core/dev.c:1762)
__dev_change_flags (net/core/dev.c:10022)
netif_change_flags (net/core/dev.c:10087)
do_setlink.isra.0 (net/core/rtnetlink.c:3294)
rtnl_setlink (net/core/rtnetlink.c:3633)
An unprivileged user can set this up in its own user and network
namespace.
Check that an 802.3ad slave is an Ethernet device before the type
handling, for every slave.
Fixes: c84fcb79e5db ("bonding: limit BOND_MODE_8023AD to Ethernet devices")
Suggested-by: Jay Vosburgh <jv@xxxxxxxxxxxxx>
Signed-off-by: Kyuwon Cho <kyuwoncho18@xxxxxxxxx>
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
---
v2:
- Move the check above the type handling, as Jay suggested, so it
covers every slave. There is no functional change: the bond mode
cannot change while it has slaves, and a later slave of another type
was already rejected, only with a different message. Kept Eric's
Reviewed-by.
v1: https://lore.kernel.org/netdev/179500849159.1877154.14715369660816392826@xxxxxxxxx/
The patch was written with LLM assistance; we reviewed and tested it.
With it, our reproducer no longer triggers the report, and enslaving
Ethernet devices into an 802.3ad bond, or a non-Ethernet device into
an active-backup bond, works as before.
drivers/net/bonding/bond_main.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 042d7c75548f..bcc12ef34d9a 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1951,6 +1951,13 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
return -EPERM;
}
+ if (slave_dev->type != ARPHRD_ETHER &&
+ BOND_MODE(bond) == BOND_MODE_8023AD) {
+ SLAVE_NL_ERR(bond_dev, slave_dev, extack,
+ "8023AD mode requires Ethernet devices");
+ return -EINVAL;
+ }
+
/* set bonding device ether type by slave - bonding netdevices are
* created with ether_setup, so when the slave type is not ARPHRD_ETHER
* there is a need to override some of the type dependent attribs/funcs.
@@ -1960,12 +1967,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev,
*/
if (!bond_has_slaves(bond)) {
if (bond_dev->type != slave_dev->type) {
- if (slave_dev->type != ARPHRD_ETHER &&
- BOND_MODE(bond) == BOND_MODE_8023AD) {
- SLAVE_NL_ERR(bond_dev, slave_dev, extack,
- "8023AD mode requires Ethernet devices");
- return -EINVAL;
- }
slave_dbg(bond_dev, slave_dev, "change device type from %d to %d\n",
bond_dev->type, slave_dev->type);