[PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status

From: Omokefe Emmanuel Onanaroghene

Date: Wed Nov 18 2026 - 19:30:30 EST


Four checks in tools/testing/selftests/net/veth.sh report failures
without setting ret, allowing the script to exit 0 even when a check
fails. Set ret=1 in chk_channels() and the three "bad setting"
negative tests identified by Tianyi during review of v2.

Patch 3 fixes the invalid TX channel test, which used nproc + 1
to determine an out-of-range value. However, nproc can be lower
than num_possible_cpus() when CPU affinity or cpusets restrict
a process, meaning the kernel may accept the requested queue count.
This could cause false failures on a correctly functioning
kernel once earlier patches propagated test failures.

Use the kernel-reported max_tx + 1 instead, ensuring the
attempted value always exceeds the device's supported maximum.
Spotted by Sashiko AI review of v2.

Changes v3 -> v4:
- Patch 2: use if/else instead of "&& { ...; } ||" chains, keep
lines within 80 columns (thanks Tianyi for the review).
- Add patch 3 deriving the invalid tx value from the kernel maximum.

Changes v2 -> v3:
- Add Tianyi Gao's Tested-by to patch 1 (thanks!).
- Add patch 2 fixing the remaining three checks.

Changes v1 -> v2:
- Correct Fixes tag to 1ec2230fc721.

Omokefe Emmanuel Onanaroghene (3):
selftests: net: veth: propagate channel-check failures to exit status
selftests: net: veth: propagate bad-settings check failures to exit
status
selftests: net: veth: derive invalid-tx test value from kernel max

tools/testing/selftests/net/veth.sh | 31 +++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)

--
2.43.0