Re: [PATCH v2 09/16] sched/deadline: Reset the deadline and the runtime with the parameters
From: sashiko-bot
Date: Wed Nov 18 2026 - 16:44:43 EST
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] sched/deadline: donor runtime and deadline retained after PI
deboost
- [Medium] sched/deadline: uncanceled dl_timer in __dl_clear_params()
--
commit d69ea33f8330709357d7bb1bbbe6f7eeb0c68972
Author: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
sched/deadline: Reset the deadline and the runtime with the parameters
This commit resets a deadline entity's runtime and deadline in
__dl_clear_params() and upon deboost in switched_from_dl() so that its next
entry into SCHED_DEADLINE starts a new period.
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 71b1c155c2424..d6d2657dcddd6 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -3569,6 +3569,16 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
> if (task_on_rq_queued(p) && p->dl.dl_runtime)
> task_non_contending(&p->dl, false);
>
> + /*
> + * A task with no parameters of its own was boosted into the class.
> + * Its deadline and runtime are the donor's. Reset them, so that its
> + * next entry into the class starts a new period.
> + */
> + if (!p->dl.dl_runtime) {
> + p->dl.deadline = 0;
> + p->dl.runtime = 0;
> + }
> +
> /*
> * In case a task is setscheduled out from SCHED_DEADLINE we need to
> * keep track of that on its cpuset (for correct bandwidth tracking).
[Severity: Medium]
Can a task still retain the donor's runtime and deadline after a PI deboost
when p->dl.dl_runtime is non-zero?
If a task that left SCHED_DEADLINE before its 0-lag time is PI-boosted by a
deadline waiter before inactive_timer fires, switched_to_dl() cancels
inactive_timer and replenish_dl_entity() overwrites p->dl.deadline and
p->dl.runtime from the donor while p->dl.dl_runtime still holds the task's
own prior parameter. When the task is deboosted, switched_from_dl() sees
p->dl.dl_runtime != 0, skips this reset, and passes the donor's deadline and
runtime to task_non_contending(), allowing the task to run on the donor's
runtime if it re-enters SCHED_DEADLINE before that deadline.
Similarly, if a non-deadline task is switched to SCHED_DEADLINE via
sched_setattr() while PI-boosted, prev_class and next_class are both
dl_sched_class, so neither switched_from_dl() nor switched_to_dl() runs.
__setparam_dl() sets p->dl.dl_runtime without clearing the donor's deadline
and runtime (and for a sleeping task, skipping switched_to_dl() also misses
add_rq_bw()), so when rt_mutex_setprio() later restores p->dl.pi_se = &p->dl,
enqueue_dl_entity() sees the donor's future deadline and skips
setup_new_dl_entity().
> @@ -3984,7 +3994,8 @@ bool __checkparam_dl(const struct sched_attr *attr)
> }
>
> /*
> - * This function clears the sched_dl_entity static params.
> + * Clear the static parameters of @dl_se. Also reset its deadline and its
> + * runtime, so that its next enqueue starts a new period.
> */
> static void __dl_clear_params(struct sched_dl_entity *dl_se)
> {
> @@ -3995,6 +4006,9 @@ static void __dl_clear_params(struct sched_dl_entity *dl_se)
> dl_se->dl_bw = 0;
> dl_se->dl_density = 0;
>
> + dl_se->deadline = 0;
> + dl_se->runtime = 0;
> +
> dl_se->dl_throttled = 0;
> dl_se->dl_yielded = 0;
> dl_se->dl_non_contending = 0;
[Severity: Medium]
Does zeroing dl_se->deadline, dl_se->runtime, and dl_se->dl_throttled here
without canceling dl_se->dl_timer leave a stale replenishment timer queued
from the old period?
If a task throttles when its 0-lag time is earlier than dl_next_period(dl_se)
(such as after sched_yield() with positive remaining runtime, or with a
constrained deadline dl_deadline < dl_period) and leaves SCHED_DEADLINE,
__dl_clear_params() runs at the 0-lag time while dl_se->dl_timer is still
queued for the old period end. If the task re-enters SCHED_DEADLINE and
throttles in its new period before that old timer expires, start_dl_timer()
sees hrtimer_is_queued(&dl_se->dl_timer) and skips arming the timer for the
new period, so dl_task_timer() replenishes and unthrottles the task at the
old period boundary instead.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795037078.git.mathieu.desnoyers@xxxxxxxxxxxx?part=9