Re: [PATCH] tracing: Reject .function on the function trace event

From: Steven Rostedt

Date: Wed Nov 18 2026 - 15:32:31 EST


On Sat, 14 Nov 2026 19:59:14 +0000
David Carlier <devnexen@xxxxxxxxx> wrote:

> For the function event, parse_pred() handles the .function suffix
> before the ftrace_event_is_function() case, so "ip.function == schedule"
> builds a predicate with no regex. Setting it through perf then
> dereferences the NULL pred->regex in ftrace_function_set_filter_pred().
>
> The "ip" field of that event already takes a function name, so reject
> the suffix there.
>
> Fixes: e6745a4da964 ("tracing: Add a way to filter function addresses to function names")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: David Carlier <devnexen@xxxxxxxxx>
> ---
> kernel/trace/trace_events_filter.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index c10951bcfc5f..11bb751c4388 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -1743,6 +1743,12 @@ static int parse_pred(const char *str, void *data,
> pred->op = op;
>
> if (function) {
> + /* Function events already take a function name on 'ip' */
> + if (ftrace_event_is_function(call)) {
> + parse_error(pe, FILT_ERR_ILLEGAL_FIELD_OP, pos + i);
> + goto err_free;
> + }
> +
> /* The field must be the same size as long */
> if (field->size != sizeof(long)) {
> parse_error(pe, FILT_ERR_ILLEGAL_FIELD_OP, pos + i);

Instead of rejecting it, why not just ignore it?

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index a1c298210059..e64c44ab3ee5 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -1742,7 +1742,9 @@ static int parse_pred(const char *str, void *data,

/* See if the field is a kernel function name */
if ((len = str_has_prefix(str + i, ".function"))) {
- function = true;
+ /* Ignore if event is already a function */
+ if (!ftrace_event_is_function(call))
+ function = true;
i += len;
}

The above fixes the issue as well, and allows things to work as expected.

-- Steve