Re: [PATCH net-next v4 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios
From: Joseph Telaak
Date: Wed Nov 18 2026 - 15:16:59 EST
On Wed, Nov 18, 2026 at 12:33:56PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Medium]
> If the switch node has reset-gpios, can the reset still be skipped here
> with no message at all?
Only in a kernel built without RESET_CONTROLLER or without RESET_GPIO,
and then the switch runs as the bootloader left it, as it did before
this patch. That is how an optional reset control behaves in every
driver that uses one. The driver uses the reset controller API rather
than devm_gpiod_get_optional() because Daniel asked for it in v1.
On the SF19A2890, the board this is for, the SoC's peripheral clock and
reset driver (under review on linux-clk) selects RESET_CONTROLLER, so
the imply does enable RESET_GPIO there by default. Selecting
RESET_CONTROLLER from this driver would turn the reset framework on in
every config that builds it, for one GPIO line; imply only takes effect
where RESET_GPIO can be enabled.
> Does this pulse the reset again on every probe attempt after
> -EPROBE_DEFER?
Yes, as in the realtek DSA drivers. The v4 changelog says why the pulse
stays in probe.
Joseph