Re: [PATCH v2 1/5] locking/rtmutex: Stop spinning on the owner when the waiter is woken
From: Mathieu Desnoyers
Date: Wed Nov 18 2026 - 12:29:04 EST
Hi Sebastian,
> > I kept the check for TASK_UNINTERRUPTIBLE on the rt_mutex side. A
> > ww_mutex wound also wakes an uninterruptible waiter, and the ABBA case
> > of patch 5 needs the spin to stop there.
>
> Not sure what is related to. I don't see this in this patch.
> TASK_UNINTERRUPTIBLE vs TASK_INTERRUPTIBLE would make a difference for
> signals here.
Sorry, that was unclear. The patch tests no state. You had suggested
to limit the check to !TASK_UNINTERRUPTIBLE. I did not do that. A
ww_mutex waiter sleeps in TASK_UNINTERRUPTIBLE, and the wound wakes it.
That is the ABBA case of patch 5. So the spin must stop for an
uninterruptible waiter too.
> For my taste this is overly verbose. In the spirit of "ain't nobody got
> time for that" what about
[...]
I will take your text in the next version.
> I agree with the change as-is so
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Thanks!
> /* If became running, trylock again or abort (signal/
> * timeout)
> */
I will take this comment.
> I would drop this entirely. It says below that the check is for signal/
> timeout which is something we don't have here. So I don't think this is
> required.
I will drop it.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com