[PATCH RFC v3 27/31] drm/tests: atomic: add tests for drm_atomic_shutdown_encoder()

From: Luca Ceresoli

Date: Wed Nov 18 2026 - 11:54:29 EST


Add KUnit tests to exercise the newly added drm_atomic_shutdown_encoder(),
including in the case of a card with multiple CRTCs.

Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

---

New patch in v3
---
drivers/gpu/drm/tests/drm_bridge_test.c | 209 ++++++++++++++++++++++++++++++++
1 file changed, 209 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_bridge_test.c b/drivers/gpu/drm/tests/drm_bridge_test.c
index 15583ade8494..ee10c8801fb1 100644
--- a/drivers/gpu/drm/tests/drm_bridge_test.c
+++ b/drivers/gpu/drm/tests/drm_bridge_test.c
@@ -5,6 +5,7 @@
#include <linux/cleanup.h>
#include <linux/media-bus-format.h>

+#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_atomic_state_helper.h>
#include <drm/drm_atomic_uapi.h>
@@ -945,6 +946,213 @@ static struct kunit_suite drm_bridge_alloc_test_suite = {
.test_cases = drm_bridge_alloc_tests,
};

+/*
+ * Two CRTC/encoder/bridge/connector pipelines on the same DRM device, to
+ * check that drm_atomic_shutdown_encoder() only stops one.
+ */
+struct drm_bridge_two_priv {
+ struct drm_device drm;
+ struct drm_plane *plane[2];
+ struct drm_crtc *crtc[2];
+ struct drm_encoder encoder[2];
+ struct drm_bridge_priv *bridge[2];
+ struct drm_connector *connector[2];
+};
+
+static const struct drm_bridge_funcs drm_test_bridge_atomic_no_destroy_funcs = {
+ .atomic_enable = drm_test_bridge_atomic_enable,
+ .atomic_disable = drm_test_bridge_atomic_disable,
+ .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
+ .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
+ .atomic_create_state = drm_atomic_helper_bridge_create_state,
+};
+
+static struct drm_bridge_two_priv *
+drm_test_bridge_two_init(struct kunit *test)
+{
+ struct drm_bridge_two_priv *priv;
+ struct drm_device *drm;
+ struct device *dev;
+ int i, ret;
+
+ dev = drm_kunit_helper_alloc_device(test);
+ if (IS_ERR(dev))
+ return ERR_CAST(dev);
+
+ priv = drm_kunit_helper_alloc_drm_device(test, dev, struct drm_bridge_two_priv,
+ drm, DRIVER_MODESET | DRIVER_ATOMIC);
+ if (IS_ERR(priv))
+ return priv;
+
+ drm = &priv->drm;
+
+ for (i = 0; i < 2; i++) {
+ priv->bridge[i] = devm_drm_bridge_alloc(dev, struct drm_bridge_priv, bridge,
+ &drm_test_bridge_atomic_no_destroy_funcs);
+ if (IS_ERR(priv->bridge[i]))
+ return ERR_CAST(priv->bridge[i]);
+
+ priv->plane[i] = drm_kunit_helper_create_primary_plane(test, drm,
+ NULL, NULL, NULL, 0, NULL);
+ if (IS_ERR(priv->plane[i]))
+ return ERR_CAST(priv->plane[i]);
+
+ priv->crtc[i] = drm_kunit_helper_create_crtc(test, drm,
+ priv->plane[i], NULL, NULL, NULL);
+ if (IS_ERR(priv->crtc[i]))
+ return ERR_CAST(priv->crtc[i]);
+
+ ret = drmm_encoder_init(drm, &priv->encoder[i], NULL, DRM_MODE_ENCODER_TMDS, NULL);
+ if (ret)
+ return ERR_PTR(ret);
+
+ priv->encoder[i].possible_crtcs = drm_crtc_mask(priv->crtc[i]);
+
+ priv->bridge[i]->bridge.type = DRM_MODE_CONNECTOR_VIRTUAL;
+
+ ret = drm_kunit_bridge_add(test, &priv->bridge[i]->bridge);
+ if (ret)
+ return ERR_PTR(ret);
+
+ ret = drm_bridge_attach(&priv->encoder[i], &priv->bridge[i]->bridge, NULL, 0);
+ if (ret)
+ return ERR_PTR(ret);
+
+ priv->connector[i] = drm_bridge_connector_init(drm, &priv->encoder[i]);
+ if (IS_ERR(priv->connector[i]))
+ return ERR_CAST(priv->connector[i]);
+ }
+
+ drm_mode_config_reset(drm);
+
+ return priv;
+}
+
+static int drm_test_enable_pipeline(struct kunit *test,
+ struct drm_device *drm,
+ struct drm_crtc *crtc,
+ struct drm_connector *connector,
+ const struct drm_display_mode *mode)
+{
+ struct drm_modeset_acquire_ctx ctx;
+ int ret;
+
+ drm_modeset_acquire_init(&ctx, 0);
+
+retry:
+ ret = drm_kunit_helper_enable_crtc_connector(test, drm, crtc, connector, mode, &ctx);
+ if (ret == -EDEADLK) {
+ drm_modeset_backoff(&ctx);
+ goto retry;
+ }
+
+ drm_modeset_drop_locks(&ctx);
+ drm_modeset_acquire_fini(&ctx);
+
+ return ret;
+}
+
+/*
+ * Test that drm_atomic_shutdown_encoder() disables the CRTC feeding the
+ * encoder and detaches its connector.
+ */
+static void drm_test_drm_atomic_shutdown_encoder(struct kunit *test)
+{
+ struct drm_bridge_init_priv *priv;
+ struct drm_display_mode *mode;
+ struct drm_bridge_priv *bridge_priv;
+ int ret;
+
+ priv = drm_test_bridge_init(test, &drm_test_bridge_atomic_funcs);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
+
+ mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
+
+ ret = drm_test_enable_pipeline(test, &priv->drm, priv->crtc, priv->connector, mode);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ bridge_priv = priv->test_bridge;
+ KUNIT_ASSERT_EQ(test, bridge_priv->enable_count, 1);
+ KUNIT_ASSERT_EQ(test, bridge_priv->disable_count, 0);
+ KUNIT_ASSERT_PTR_EQ(test, priv->connector->state->crtc, priv->crtc);
+
+ drm_atomic_shutdown_encoder(&priv->encoder);
+
+ KUNIT_EXPECT_EQ(test, bridge_priv->disable_count, 1);
+ KUNIT_EXPECT_NULL(test, priv->connector->state->crtc);
+ KUNIT_EXPECT_FALSE(test, priv->crtc->state->active);
+}
+
+/*
+ * Test that drm_atomic_shutdown_encoder() is a no-op when the encoder is not
+ * driving any output.
+ */
+static void drm_test_drm_atomic_shutdown_encoder_disabled(struct kunit *test)
+{
+ struct drm_bridge_init_priv *priv;
+ struct drm_bridge_priv *bridge_priv;
+
+ priv = drm_test_bridge_init(test, &drm_test_bridge_atomic_funcs);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
+
+ bridge_priv = priv->test_bridge;
+
+ drm_atomic_shutdown_encoder(&priv->encoder);
+
+ KUNIT_EXPECT_EQ(test, bridge_priv->enable_count, 0);
+ KUNIT_EXPECT_EQ(test, bridge_priv->disable_count, 0);
+ KUNIT_EXPECT_NULL(test, priv->connector->state->crtc);
+}
+
+/*
+ * Test that drm_atomic_shutdown_encoder() only stops the pipeline of the
+ * given encoder and leaves the other CRTC untouched.
+ */
+static void drm_test_drm_atomic_shutdown_encoder_two_crtcs(struct kunit *test)
+{
+ struct drm_bridge_two_priv *priv;
+ struct drm_display_mode *mode;
+ int ret;
+
+ priv = drm_test_bridge_two_init(test);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
+
+ mode = drm_kunit_display_mode_from_cea_vic(test, &priv->drm, 16);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mode);
+
+ ret = drm_test_enable_pipeline(test, &priv->drm, priv->crtc[0], priv->connector[0], mode);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ ret = drm_test_enable_pipeline(test, &priv->drm, priv->crtc[1], priv->connector[1], mode);
+ KUNIT_ASSERT_EQ(test, ret, 0);
+
+ KUNIT_ASSERT_EQ(test, priv->bridge[0]->enable_count, 1);
+ KUNIT_ASSERT_EQ(test, priv->bridge[1]->enable_count, 1);
+
+ drm_atomic_shutdown_encoder(&priv->encoder[0]);
+
+ KUNIT_EXPECT_EQ(test, priv->bridge[0]->disable_count, 1);
+ KUNIT_EXPECT_NULL(test, priv->connector[0]->state->crtc);
+ KUNIT_EXPECT_FALSE(test, priv->crtc[0]->state->active);
+
+ KUNIT_EXPECT_EQ(test, priv->bridge[1]->disable_count, 0);
+ KUNIT_EXPECT_PTR_EQ(test, priv->connector[1]->state->crtc, priv->crtc[1]);
+ KUNIT_EXPECT_TRUE(test, priv->crtc[1]->state->active);
+}
+
+static struct kunit_case drm_atomic_shutdown_encoder_tests[] = {
+ KUNIT_CASE(drm_test_drm_atomic_shutdown_encoder),
+ KUNIT_CASE(drm_test_drm_atomic_shutdown_encoder_disabled),
+ KUNIT_CASE(drm_test_drm_atomic_shutdown_encoder_two_crtcs),
+ { }
+};
+
+static struct kunit_suite drm_atomic_shutdown_encoder_test_suite = {
+ .name = "drm_atomic_shutdown_encoder",
+ .test_cases = drm_atomic_shutdown_encoder_tests,
+};
+
/**
* drm_test_bridge_chain_verify_fmt - Verify bridge chain format selection
* @test: pointer to KUnit test object
@@ -1375,6 +1583,7 @@ kunit_test_suites(
&drm_bridge_get_current_state_test_suite,
&drm_bridge_helper_reset_crtc_test_suite,
&drm_bridge_alloc_test_suite,
+ &drm_atomic_shutdown_encoder_test_suite,
&drm_bridge_bus_fmt_test_suite,
);


--
2.56.1