Re: [PATCH v3 01/11] KVM: arm64: guest_memfd: Check mmap support when preparing memslot
From: Suzuki K Poulose
Date: Wed Nov 18 2026 - 05:34:47 EST
Hi Steven
On 17/11/2026 14:05, Fuad Tabba wrote:
Hi Steven,
On Mon, 16 Nov 2026 16:43:47 +0000, Steven Price <steven.price@xxxxxxx> wrote:
Check the guest_memfd backing file when deciding whether an arm64
memslot has mappable memory rather than checking whether the slot is
gmem only. A public helper function is added to be able to reuse the
static kvm_gmem_supports_mmap() function.
nit: could the message say why this is needed? It's a no-op until
patch 8 defines kvm_arch_has_private_mem(), which makes every
guest_memfd slot gmem-only.
I still don't understand why this is needed. For arm64 we have always
prevented guest_memfd without MMAP, in kvm_arch_prepare_memory_region().
Suzuki
Cheers,
/fuad