Re: [PATCH v3 1/3] bit_spinlock: Fix the __bitlock() definition
From: Marco Elver
Date: Wed Nov 18 2026 - 04:49:32 EST
On Tue, 17 Nov 2026 at 00:01, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> Surround the bitnum argument and the entire __bitlock() macro expansion
> with parentheses because bitnum could be an expression that includes an
> operator with a lower precedence than the addition operator (e.g. the
> exclusive-or operator) and to prevent operator precedence issues in
> callers.
>
> Reviewed-by: Marco Elver <elver@xxxxxxxxxx>
> Fixes: eb7d96a13bf4 ("bit_spinlock: Support Clang's context analysis")
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
My Reviewed-by on this is still valid.
Thanks,
-- Marco