Re: [PATCH] virt/steal_governor: Remove redundant delay filed
From: Shrikanth Hegde
Date: Wed Nov 18 2026 - 04:04:39 EST
Hi.
On 11/18/26 12:57 PM, Fushuai Wang wrote:
From: Fushuai Wang <wangfushuai@xxxxxxxxx>
The 'delay' member in struct steal_governor is just a cache for
msecs_to_jiffies(interval_ms). The duplicate state is confusing
and adds no value. Use msecs_to_jiffies() directly at the schedule
site and remove the 'delay' field.
I guess you haven't seen the below change which is in tip tree.
https://lore.kernel.org/all/179421651800.2093942.14148413791803216183.tip-bot2@tip-bot2/
With that, we don't need the below change, since there is no more redundant field.
Signed-off-by: Fushuai Wang <wangfushuai@xxxxxxxxx>
---
drivers/virt/steal_governor.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/virt/steal_governor.c b/drivers/virt/steal_governor.c
index 6e31f9923dea..8af6c02c7e77 100644
--- a/drivers/virt/steal_governor.c
+++ b/drivers/virt/steal_governor.c
@@ -38,7 +38,6 @@
struct steal_governor {
ktime_t time;
u64 steal;
- unsigned long delay;
unsigned int interval_ms;
unsigned int high_threshold;
unsigned int low_threshold;
@@ -252,7 +251,7 @@ static void steal_governor_loop(struct work_struct *work)
}
requeue_work:
- schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
+ schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
}
static int __init steal_governor_init(void)
@@ -270,11 +269,10 @@ static int __init steal_governor_init(void)
return -EINVAL;
}
- sg_ctx.delay = msecs_to_jiffies(sg_ctx.interval_ms);
INIT_DELAYED_WORK(&sg_ctx.work, steal_governor_loop);
sg_ctx.steal = get_system_steal_time();
sg_ctx.time = ktime_get();
- schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
+ schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
pr_info("enabled. interval: %ums, high_threshold: %u, low_threshold: %u\n",
sg_ctx.interval_ms, sg_ctx.high_threshold, sg_ctx.low_threshold);