Re: [PATCH v5 1/2] dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC

From: Ishu Brar

Date: Wed Nov 18 2026 - 03:59:25 EST


On Mon, 16 Nov 2026 12:03:41 +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 16, 2026 at 11:58:00AM +0530, Ishu Brar wrote:
> +
>> + clocks:
>> + items:
>> + - description: aggre UFS PHY AXI clock
>> + - description: aggre USB3 PRIM AXI clock
>> +
>> + interconnect:
>> + type: object
>> + description:
>> + The interconnect providers do not have a separate QoS register space,
>> + but share parent's space.
>
> Sashiko claims these do not share address space.

Right, the description is wrong for two of the three children. Only
compute-noc (under aggre2-noc) has QoS registers, and they are inside
the aggre2-noc register space. mc-virt (under gem-noc) and qup-virt
(under system-noc) are virtual BCM voters with no registers at all.

v6 will describe it like that, allow each child only under its own
parent, and also add the IPA clock to aggre2-noc, which the second
Sashiko point is right about (the IPA port QoS registers need it).

Best regards,
Ishu