[PATCH v1 3/4] perf metricgroup: Fix realloc() leaks in resolve_metric() and __add_metric()

From: Ian Rogers

Date: Wed Nov 18 2026 - 02:55:43 EST


In resolve_metric(), growing the pending array assigns the result of
realloc() directly back to pending; if realloc() fails after earlier
iterations succeeded, the existing pending allocation is overwritten
with NULL and leaked.

Similarly, in __add_metric(), assigning realloc() directly to
root_metric->metric_refs overwrites the existing pointer with NULL on
failure, preventing metric__free(root_metric) in the root caller from
freeing the prior metric_refs array.

Use temporary pointers for both realloc() calls, freeing pending before
returning -ENOMEM in resolve_metric() and preserving
root_metric->metric_refs for metric__free() in __add_metric().

Fixes: 80be6434c36f ("perf metric: Modify resolution and recursion check")
Fixes: 46bdc0bf8d21 ("perf metric: Simplify metric_refs calculation")
Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/util/metricgroup.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 779fe56..489f13b 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -771,10 +771,15 @@ static int resolve_metric(struct list_head *metric_list,
if (pmu_metrics_table__find_metric(table, pmu, cur->pkey,
metricgroup__find_metric_callback,
&pm) != PMU_METRICS__NOT_FOUND) {
- pending = realloc(pending,
- (pending_cnt + 1) * sizeof(struct to_resolve));
- if (!pending)
+ struct to_resolve *new_pending;
+
+ new_pending = realloc(pending,
+ (pending_cnt + 1) * sizeof(struct to_resolve));
+ if (!new_pending) {
+ free(pending);
return -ENOMEM;
+ }
+ pending = new_pending;

memcpy(&pending[pending_cnt].pm, &pm, sizeof(pm));
pending[pending_cnt].key = cur->pkey;
@@ -863,6 +868,7 @@ static int __add_metric(struct list_head *metric_list,
return -ENOMEM;

} else {
+ struct metric_ref *new_refs;
int cnt = 0;

/*
@@ -879,10 +885,11 @@ static int __add_metric(struct list_head *metric_list,
}

/* Create reference. Need space for the entry and the terminator. */
- root_metric->metric_refs = realloc(root_metric->metric_refs,
- (cnt + 2) * sizeof(struct metric_ref));
- if (!root_metric->metric_refs)
+ new_refs = realloc(root_metric->metric_refs,
+ (cnt + 2) * sizeof(struct metric_ref));
+ if (!new_refs)
return -ENOMEM;
+ root_metric->metric_refs = new_refs;

/*
* Intentionally passing just const char pointers,
--
2.56.1.703.gf848ed807c-goog