[PATCH v1 0/4] perf tools: Fix thread cache race, stat per-pkg delta bug, and memory leaks
From: Ian Rogers
Date: Wed Nov 18 2026 - 02:55:30 EST
Four standalone bug fixes for pre-existing issues in perf tools uncovered
during Sashiko review:
1. util/threads.c: Fix a race between threads__find() and
threads__remove() where dropping table->lock between lookup and
updating table->last_match could resurrect a removed thread in
last_match (and avoid taking down_write(&table->lock) on last_match
cache hits).
2. util/stat.c: Fix process_counter_values() passing a static zero
struct into evsel__compute_deltas() when skipping per-pkg CPUs, which
underflowed and corrupted the static struct in place and clobbered
prev_raw_counts when a previously active CPU was later skipped.
3. util/metricgroup.c: Fix realloc() failure memory leaks of pending in
resolve_metric() and root_metric->metric_refs in __add_metric().
4. util/pmu.c: Free alias on parse_double() and io__getline() error
returns in perf_pmu__new_alias().
AI Assistance Disclosure (per Documentation/process/coding-assistants.rst
and Documentation/process/generated-content.rst):
- Tools used: Sashiko automated patch review (sashiko.dev) for bug
detection, and Google Antigravity / Jetski coding assistant for root
cause verification and patch drafting.
- Summary of prompts and assistance: Verified four pre-existing issues
flagged by Sashiko during review of the perf generic hashmap series and
prepared standalone fixes with Fixes tags against perf-tools-next.
- Testing performed: Built on perf-tools-next (b7ff10b9ddec) with GCC,
Clang (BUILD_NONDISTRO=1), and DEBUG=1 (REFCNT_CHECKING=1); ran perf
test (Sysfs PMU, PMU JSON event, Symbols, and perf stat suites) and
scripts/checkpatch.pl.
Ian Rogers (4):
perf threads: Don't resurrect removed threads in last_match
perf stat: Don't corrupt zero or prev_raw_counts on skipped per-pkg
CPUs
perf metricgroup: Fix realloc() leaks in resolve_metric() and
__add_metric()
perf pmu: Free alias on error paths in perf_pmu__new_alias()
tools/perf/util/metricgroup.c | 19 +++++++++++++------
tools/perf/util/pmu.c | 5 ++++-
tools/perf/util/stat.c | 10 +++++-----
tools/perf/util/threads.c | 16 +++++++++++-----
4 files changed, 33 insertions(+), 17 deletions(-)
base-commit: b7ff10b9ddec8da75304c40fe4abf1ee4f9f0a43
--
2.56.1.703.gf848ed807c-goog