Re: [PATCH v2 00/13] arm64: add Synaptics SL2610 SoCs and RDK boards

From: Richard GENOUD

Date: Wed Nov 18 2026 - 02:54:21 EST


Le 16/11/2026 à 13:06, Jisheng Zhang a écrit :
On Sun, Nov 15, 2026 at 06:23:39PM +0800, Jisheng Zhang wrote:
Add initial support for the Synaptics SL261X SoCs and corresponding
RDK boards.

The SL261X SoCs include five pin-to-pin compatible SoCs: SL2611, SL2613,
SL2615, SL2617, and SL2619.

Only reset, pinctrl, clk/pll, uart, gpio, i2c, spi, i3c are included in
this series. The support for Ethernet, USB, SDHCI, CAN, DMAC, XSPI will
be submitted after this series is merged.

since v1:
- rebase on latest rcN
- drop some patches which have been merged
- let the "gbl" node export pinctrl/reset/clk devices with
MFD_CELL_NAME()
- use <linux/platform_device.h> instead of <linux/mod_devicetable.h>
- adopt some coding suggestions from Uwe
- Use 0 and 1 to select normal and strong pull-up on 10-bit pads

Other SoCs doesn't use this defintion for pull up or strong pull up.
After consulting our HW people, the strong pull up isn't used at
all, so I will remove strong pull up support in newer version. We can
add back its support when it's really needed in the future, nothing
breaks.
I've found a similar definition here:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml#L73-L78
But also a plain new property here:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/starfive,jh7100-pinctrl.yaml#L153-L155
And another with the real strong pull-up value:
https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml#L94-L99
As you said, if it's not used, we can skip it and add a property in
the future (or the real value if we have it).

But we won't be able to use 1 for strong and 0 for normal.

Regards,
Richard

- collect Acked-by tag

Jisheng Zhang (13):
arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs
pinctrl: berlin: use u16 instead of u8 for the offset
pinctrl: berlin: enable module build support
pinctrl: berlin: add optional pinconf support
dt-bindings: soc: synaptics: add SL2610 system controllers
soc: synaptics: add SL2610 system controller support
reset: add Synaptics SL2610 reset controller support
pinctrl: berlin: add Synaptics SL2610 pin controller support
clk: berlin: add Synaptics clock controller helpers
clk: berlin: add Synaptics SL2610 clocks and PLLs
dt-bindings: arm: berlin: add Synaptics SL2610 SoCs and RDK boards
arm64: dts: synaptics: add SL2610 family SoCs
arm64: dts: synaptics: add SL2610 family RDK boards

.../bindings/arm/marvell,berlin.yaml | 20 +
.../soc/synaptics/syna,sl2610-soc-syscon.yaml | 178 ++++
MAINTAINERS | 8 +
arch/arm64/Kconfig.platforms | 4 +-
arch/arm64/boot/dts/synaptics/Makefile | 5 +
arch/arm64/boot/dts/synaptics/sl2611-rdk.dts | 16 +
arch/arm64/boot/dts/synaptics/sl2611.dtsi | 457 +++++++++++
arch/arm64/boot/dts/synaptics/sl2613-rdk.dts | 16 +
arch/arm64/boot/dts/synaptics/sl2613.dtsi | 12 +
arch/arm64/boot/dts/synaptics/sl2615-rdk.dts | 16 +
arch/arm64/boot/dts/synaptics/sl2615.dtsi | 46 ++
arch/arm64/boot/dts/synaptics/sl2617-rdk.dts | 16 +
arch/arm64/boot/dts/synaptics/sl2617.dtsi | 46 ++
arch/arm64/boot/dts/synaptics/sl2619-rdk.dts | 16 +
arch/arm64/boot/dts/synaptics/sl2619.dtsi | 44 +
.../boot/dts/synaptics/sl261x-rdk-common.dtsi | 135 ++++
drivers/clk/Kconfig | 1 +
drivers/clk/berlin/Kconfig | 34 +
drivers/clk/berlin/Makefile | 4 +
drivers/clk/berlin/clk-sl2610.c | 360 +++++++++
drivers/clk/berlin/sl-clk.c | 279 +++++++
drivers/clk/berlin/sl-clk.h | 31 +
drivers/clk/berlin/sl-sysmgr-clk.c | 241 ++++++
drivers/clk/berlin/sl-sysmgr-clk.h | 44 +
drivers/clk/berlin/sl2610-pll.c | 145 ++++
drivers/clk/berlin/sl2610-pll.h | 14 +
drivers/pinctrl/berlin/Kconfig | 16 +
drivers/pinctrl/berlin/Makefile | 1 +
drivers/pinctrl/berlin/berlin.c | 259 +++++-
drivers/pinctrl/berlin/berlin.h | 17 +-
drivers/pinctrl/berlin/pinctrl-sl2610.c | 759 ++++++++++++++++++
drivers/reset/Kconfig | 13 +
drivers/reset/Makefile | 1 +
drivers/reset/reset-sl2610.c | 224 ++++++
drivers/soc/Kconfig | 1 +
drivers/soc/Makefile | 1 +
drivers/soc/synaptics/Kconfig | 14 +
drivers/soc/synaptics/Makefile | 2 +
drivers/soc/synaptics/sl2610-syscon.c | 84 ++
include/dt-bindings/clock/syna,sl2610.h | 131 +++
include/dt-bindings/reset/syna,sl2610-reset.h | 80 ++
41 files changed, 3771 insertions(+), 20 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/synaptics/syna,sl2610-soc-syscon.yaml
create mode 100644 arch/arm64/boot/dts/synaptics/sl2611-rdk.dts
create mode 100644 arch/arm64/boot/dts/synaptics/sl2611.dtsi
create mode 100644 arch/arm64/boot/dts/synaptics/sl2613-rdk.dts
create mode 100644 arch/arm64/boot/dts/synaptics/sl2613.dtsi
create mode 100644 arch/arm64/boot/dts/synaptics/sl2615-rdk.dts
create mode 100644 arch/arm64/boot/dts/synaptics/sl2615.dtsi
create mode 100644 arch/arm64/boot/dts/synaptics/sl2617-rdk.dts
create mode 100644 arch/arm64/boot/dts/synaptics/sl2617.dtsi
create mode 100644 arch/arm64/boot/dts/synaptics/sl2619-rdk.dts
create mode 100644 arch/arm64/boot/dts/synaptics/sl2619.dtsi
create mode 100644 arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi
create mode 100644 drivers/clk/berlin/Kconfig
create mode 100644 drivers/clk/berlin/clk-sl2610.c
create mode 100644 drivers/clk/berlin/sl-clk.c
create mode 100644 drivers/clk/berlin/sl-clk.h
create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.c
create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.h
create mode 100644 drivers/clk/berlin/sl2610-pll.c
create mode 100644 drivers/clk/berlin/sl2610-pll.h
create mode 100644 drivers/pinctrl/berlin/pinctrl-sl2610.c
create mode 100644 drivers/reset/reset-sl2610.c
create mode 100644 drivers/soc/synaptics/Kconfig
create mode 100644 drivers/soc/synaptics/Makefile
create mode 100644 drivers/soc/synaptics/sl2610-syscon.c
create mode 100644 include/dt-bindings/clock/syna,sl2610.h
create mode 100644 include/dt-bindings/reset/syna,sl2610-reset.h

--
2.55.0





--
Richard Genoud, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com