Re: [PATCH v3 2/2] drm/panel: add Novatek NT36525 panel driver
From: Uwe Kleine-König
Date: Wed Nov 18 2026 - 02:48:40 EST
Hello,
On Tue, Nov 17, 2026 at 08:33:19PM +0300, Adil Hüsrev Tepe wrote:
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <video/mipi_display.h>
> +
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
<linux/mod_devicetable.h> doens't only give you a definition of
of_device_id, but also pulls in a lot of unneeded stuff and thus
introduces useless build dependencies.
<drm/drm_mipi_dsi.h> already provides of_device_id, so just drop
<linux/mod_devicetable.h>.
Attachment:
signature.asc
Description: PGP signature