Re: [PATCH 1/2] mailbox: zynqmp-ipi: Fix CPU hotplug state cleanup
From: Srivatsa S. Bhat
Date: Wed Nov 18 2026 - 01:08:36 EST
On Wed, Nov 04, 2026 at 04:51:28PM +0530, Prasanna Kumar T S M wrote:
> Hi Radhey Shyam,
>
> Thanks for reviewing this.
>
> On 04-11-2026 11:23, Pandey, Radhey Shyam wrote:
> > On 11/3/2026 11:50 AM, Prasanna Kumar T S M wrote:
> > > On driver removal, the CPUHP_AP_ONLINE_DYN CPU hotplug state is removed
> > > instead of the its actual state. This can leave the mailbox driver
> > > callbacks dangling. Use the actual CPU hotplug state during driver
> > > removal.
> > >
> > > Hotplug registration failures are also ignored, allowing probe to
> > > succeed without the callbacks needed to enable interrupts on CPUs
> > > brought online later.
> > >
[...]
> > > @@ -863,15 +864,22 @@ static int xlnx_mbox_init_sgi(struct
> > > platform_device *pdev,
> > > irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
> > > /* Setup function for the CPU hot-plug cases */
> > > - cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "mailbox/sgi:starting",
> > > - xlnx_mbox_cpuhp_start, xlnx_mbox_cpuhp_down);
> > > + pdata->hp_state = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> > > + "mailbox/sgi:starting", xlnx_mbox_cpuhp_start,
> >
> > what is :starting here ?
>
> I used the existing string.
Let's please fix it while we are at it. The convention is to match the
mode in the @name argument to the CPU hotplug state that it is
associated with. So in this case, :online would be the right one to
use instead of :starting.
Also, could you consider editing the names of the callbacks for
symmetry? Ex: We can rename them to xlnx_mbox_cpuhp_startup() and
xlnx_mbox_cpuhp_teardown() instead of _start() and _down() that are
used today.
Regards,
Srivatsa