[PATCH v1 1/2] tools/mm: slabinfo: fix inverted numeric sorting

From: Xuewen Wang

Date: Wed Nov 18 2026 - 01:05:22 EST


From: Xuewen Wang <wangxuewen@xxxxxxxxxx>

The numeric branches of sort_slabs() return either zero or one for
unequal keys. Negating these values for -i never yields a positive
result, so the sort does not swap entries with different numeric keys.
For example, partial-slab counts 30, 10, 20 remain in that order
with -P -i instead of being sorted as 10, 20, 30.

Return a positive or negative result for unequal numeric keys so that
the existing inversion works for size, activity, loss and partial-slab
sorting. Preserve the alphabetic tie break for equal keys and avoid
subtracting unsigned counters.

Fixes: c09d87517298 ("slub: add slabinfo tool")
Signed-off-by: Xuewen Wang <wangxuewen@xxxxxxxxxx>
---
tools/mm/slabinfo.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c
index 48d1ee8b0e81..3e62a2fccaeb 100644
--- a/tools/mm/slabinfo.c
+++ b/tools/mm/slabinfo.c
@@ -1075,22 +1075,22 @@ static void sort_slabs(void)
if (slab_size(s1) == slab_size(s2))
result = strcasecmp(s1->name, s2->name);
else
- result = slab_size(s1) < slab_size(s2);
+ result = slab_size(s1) < slab_size(s2) ? 1 : -1;
} else if (sort_active) {
if (slab_activity(s1) == slab_activity(s2))
result = strcasecmp(s1->name, s2->name);
else
- result = slab_activity(s1) < slab_activity(s2);
+ result = slab_activity(s1) < slab_activity(s2) ? 1 : -1;
} else if (sort_loss) {
if (slab_waste(s1) == slab_waste(s2))
result = strcasecmp(s1->name, s2->name);
else
- result = slab_waste(s1) < slab_waste(s2);
+ result = slab_waste(s1) < slab_waste(s2) ? 1 : -1;
} else if (sort_partial) {
if (s1->partial == s2->partial)
result = strcasecmp(s1->name, s2->name);
else
- result = s1->partial < s2->partial;
+ result = s1->partial < s2->partial ? 1 : -1;
} else
result = strcasecmp(s1->name, s2->name);

--
2.25.1