Re: [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control
From: Sailesh-003
Date: Wed Nov 18 2026 - 01:02:23 EST
From: Sailesh Nandanavanam <saileshnandanavanam@xxxxxxxxx>
On Wed, 18 Nov 2026 SJ Park <sj@xxxxxxxxxx> wrote:
> I think the above last two expects are somewhat too much implementation detail.
> I don't think we are promising those list status. I'd prefer dropping those.
Agreed, dropping both list assertions.
> Can anything leak or corrupted if we don't call list_del() here?
No. The control is stack-allocated and damon_destroy_ctx() does not
touch call_controls, so nothing is leaked or accessed afterwards. Will
drop the list_del().
> Could we merge the above two tests into one, say, damon_test_call()?
Will merge them into damon_test_call() and send v2 as a single patch.
> Apparently this patch was meant to be sent as a part of a series with another
> patch [1] but individually sent by a setup failure. As a result, this patch is
> not reviewed by Sashiko. Could you please repost as the series?
Sorry for the mess. Since the two tests will be merged, v2 will be a
single patch, so Sashiko will review it.
Thanks,
Sailesh