[PATCH v1 14/19] ACPI: APEI: Return status from cxl_cper_post_event()
From: Pierre Gondois
Date: Tue Nov 17 2026 - 06:20:17 EST
Callers cannot tell whether cxl_cper_post_event() queued a CPER event or
discarded it. Return 0 if success and 1 if aborted. Existing callers
continue to ignore the result for now.
A worker that is already scheduled still processes the queued event, so
its schedule_work() return value does not indicate a delivery failure.
This prepares for a following patch moving PCI/CXL handling to
extlog.c.
Signed-off-by: Pierre Gondois <pierre.gondois@xxxxxxx>
---
drivers/acpi/apei/apei-internal.h | 4 ++--
drivers/acpi/apei/ghes.c | 15 ++++++++-------
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h
index f7f0ab8e5ed7f..5063c743b4cf0 100644
--- a/drivers/acpi/apei/apei-internal.h
+++ b/drivers/acpi/apei/apei-internal.h
@@ -11,8 +11,8 @@
#include <cxl/event.h>
int ghes_severity(int severity);
-void cxl_cper_post_event(enum cxl_event_type event_type,
- struct cxl_cper_event_rec *rec, u32 len);
+int cxl_cper_post_event(enum cxl_event_type event_type,
+ struct cxl_cper_event_rec *rec, u32 len);
u32 acpi_extlog_mem_err_min_len(u64 validation_bits);
void acpi_extlog_report(const struct acpi_hest_generic_status *estatus);
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index b51b621208ed1..623ac2a7f7a75 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -823,42 +823,43 @@ DEFINE_KFIFO(cxl_cper_fifo, struct cxl_cper_work_data, CXL_CPER_FIFO_DEPTH);
static DEFINE_RAW_SPINLOCK(cxl_cper_work_lock);
struct work_struct *cxl_cper_work;
-void cxl_cper_post_event(enum cxl_event_type event_type,
- struct cxl_cper_event_rec *rec, u32 len)
+int cxl_cper_post_event(enum cxl_event_type event_type,
+ struct cxl_cper_event_rec *rec, u32 len)
{
struct cxl_cper_work_data wd;
if (len < sizeof(*rec)) {
pr_err(FW_WARN "CXL CPER section too small (%u)\n", len);
- return;
+ return 1;
}
if (rec->hdr.length <= sizeof(rec->hdr) ||
rec->hdr.length > sizeof(*rec)) {
pr_err(FW_WARN "CXL CPER Invalid section length (%u)\n",
rec->hdr.length);
- return;
+ return 1;
}
if (!(rec->hdr.validation_bits & CPER_CXL_COMP_EVENT_LOG_VALID)) {
pr_err(FW_WARN "CXL CPER invalid event\n");
- return;
+ return 1;
}
guard(raw_spinlock_irqsave)(&cxl_cper_work_lock);
if (!cxl_cper_work)
- return;
+ return 1;
wd.event_type = event_type;
memcpy(&wd.rec, rec, sizeof(wd.rec));
if (!kfifo_put(&cxl_cper_fifo, wd)) {
pr_err_ratelimited("CXL CPER kfifo overflow\n");
- return;
+ return 1;
}
schedule_work(cxl_cper_work);
+ return 0;
}
int cxl_cper_register_work(struct work_struct *work)
--
2.43.0