Re: [PATCH net] net: stmmac: re-enable on-chip parity checkers for XGMAC ASP 0x2

From: Maxime Chevallier

Date: Tue Nov 17 2026 - 04:13:16 EST


Hi,

On 11/14/26 02:55, Zxyan Zhu wrote:
> Commit 669a55560e4b ("net: stmmac: Check more MAC HW features for XGMAC
> Core 3.20") made dwxgmac3_safety_feat_config() bail out early for
> asp == 0x2, assuming that configuration has no parity protection.
>
> Per the DWC_xgmac databook, the ASP field of MAC_HW_Feature3 selects:
>
> 0x1 (AS_EPPE): all automotive safety features, with ECC and parity
> ports on the external application interface
> 0x2 (AS_NEPPE): all automotive safety features, without ECC or
> parity ports on the external application interface
> 0x3 (AS_PPE): all automotive safety features, with parity ports
> on the external application interface
>
> The reset value of the field is defined as:
>
> (DWCXG_ASP_ALL && DWCXG_ASP_PPE == 1) ? "3"
> : (DWCXG_ASP_ALL && DWCXG_ASP_PPE == 0) ? "2"
> : (DWCXG_ASP_ALL && DWCXG_ASP_PPE == 2) ? "1" : "0"
>
> so ASP 0x2 implies DWCXG_ASP_ALL = 1, where the internal FSM state
> parity and timeout (MAC_FSM_Control) and the on-chip data-path parity
> (MTL_DPP_CONTROL) features exist; only the ports on the external
> application interface are absent. The early return therefore skips
> enabling safety checkers that are present in the hardware.
>
> Drop 0x2 from the condition so the FSM and data-path parity checkers
> are enabled again.
>
> Also update the safety feature descriptions printed by
> stmmac_dma_cap_show() to spell out that ASP 0x1/0x2/0x3 differ only
> in the ECC or parity ports on the external application interface; the
> previous wording, "All Safety Features without ECC or Parity",
> suggests the on-chip checkers are absent from an ASP 0x2 device.
>
> Keep the early return for ASP 0x4 (EASP), which selects only ECC
> protection for external memory and has no on-chip parity features.
>
> Tested on XGMAC 3.10 and 3.40 cores.
>
> Fixes: 669a55560e4b ("net: stmmac: Check more MAC HW features for XGMAC Core 3.20")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Zxyan Zhu <zxyan0222@xxxxxxxxx>

Seems correct to me, couldn't test it but this matches the datasheets
I have.

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Maxime