Re: [PATCH v6 0/9] dmaengine: add DMA channel bus and fsl-edma per-channel IOMMU support
From: Peng Fan
Date: Tue Nov 17 2026 - 03:30:51 EST
On Mon, Nov 16, 2026 at 03:30:21PM -0400, Jason Gunthorpe wrote:
>On Thu, Nov 12, 2026 at 03:53:03PM +0800, Peng Fan (OSS) wrote:
>> I used iommu-map for eDMA, but iommu experts rejected it:
>> "Using iommu-map to describe synthetic dma_chan_dev devices that the
>> kernel creates is the same kind of DT abuse from over here:"
>> More info: https://lore.kernel.org/all/20260917144804.GI3196566@xxxxxxxx/
>>
>> So I followed here [2] as Krzysztof wrote for QCOM VPU:
>> "Thanks Jason for context and detailed arguments. Robin did not chime in
>> yet, but from what I understood the DT-child-node approach will be the
>> way we should go here.
>>
>> I accept above point of view and I am fine with this, thus Vishnu and
>> Vikash - please go ahead with DT-child-node solution we had some time ago."
>> [2] https://lore.kernel.org/linux-iommu/c7b956a9-d3e8-4e18-b780-5d08f5cd2ca1@xxxxxxxxxx/
>>
>> This series adds per-channel DT child node support to fsl-edma and, as a
>> prerequisite, introduces a proper bus for DMA channel devices.
>
>To be fair this is discouraged too, now that I've seen 3-4 people
>trying to do exactly the same thing I'm not as positive about the
>DT-child-node hack.
I may not describe it clear in cover-letter.
I understand the concern. Let me explain why I believe it is justified here
rather than a hack.
On i.MX eDMA each channel has its own interrupt, its own register region,
and on i.MX8QM even its own power domain. Each channel may also have its
own Stream ID, or share one when SIDs are scarce. These are genuine
per-channel hardware resources, not software fiction.
In dmaengine each channel is already modeled as a channel device (see
dmaengine_chan_dev()), and this series puts those devices on a real bus
(dmaengine_chan_bus_type) as a prerequisite. The DT child node simply
describes that existing device, so its reg/interrupts/power-domains/iommus
are attached per channel instead of as index-matched flat lists on the
controller.
Given that context, do you agree that a child node per channel is the
right description here?
Thanks,
Peng
>
>Can all of you come up with a proposal that doesn't involve hacking up
>DT just to unbundle the SIDs?
>
>Jason
>