Re: [PATCH net-next] net: stmmac: dwmac-sun8i: Defer probe when the EPHY clock is not ready
From: netdev-bot+sashiko
Date: Tue Nov 17 2026 - 03:13:43 EST
Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 0 · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] The patch makes get_ephy_nodes() in
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c return -EPROBE_DEFER…
--
net: stmmac: dwmac-sun8i: Defer probe when the EPHY clock is not ready
With this patch, get_ephy_nodes() returns -EPROBE_DEFER when of_clk_get()
on the internal PHY node returns -EPROBE_DEFER. Before, it skipped the
node and the probe ended with -ENODEV. Other clock errors still skip the
node.
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 2ece7ba9dd73b..8163e49fa7ad0 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -801,8 +801,13 @@ static int get_ephy_nodes(struct stmmac_priv *priv)
> struct clk *ephy_clk;
>
> ephy_clk = of_clk_get(iphynode, 0);
> - if (IS_ERR(ephy_clk))
> + if (IS_ERR(ephy_clk)) {
> + if (PTR_ERR(ephy_clk) == -EPROBE_DEFER) {
> + of_node_put(mdio_internal);
> + return -EPROBE_DEFER;
> + }
> continue;
> + }
> gmac->rst_ephy = of_reset_control_get_exclusive(iphynode, NULL);
> if (IS_ERR(gmac->rst_ephy)) {
> ret = PTR_ERR(gmac->rst_ephy);
[Severity: High]
Does this deferral come too late in the probe?
The only caller of get_ephy_nodes() is sun8i_dwmac_probe(), and it calls
it after stmmac_pltfr_probe() has already run:
sun8i_dwmac_probe()
stmmac_pltfr_probe()
sun8i_dwmac_init() (plat->init, enables the phy regulator)
__stmmac_dvr_probe()
deasserts the stmmac reset
stmmac_mdio_register(ndev)
register_netdev(ndev)
pm_runtime_get_sync()
get_ephy_nodes()
return -EPROBE_DEFER
goto dwmac_remove
stmmac_pltfr_remove()
sun8i_dwmac_unset_syscon()
So when the new -EPROBE_DEFER is returned, the MDIO bus and an ethN
netdev already exist as children of the platform device.
Documentation/driver-api/driver-model/driver.rst says to defer as early
as possible, and it also says:
-EPROBE_DEFER must not be returned if probe() has already created
child devices, even if those child devices are removed again
in a cleanup path.
The commit message describes an EPHY clock provider that probes later.
In that case, wouldn't every deferred probe retry do all of the
following?
- power up the phy regulator
- toggle the MAC reset
- register and unregister the MDIO bus and an ethN interface that
userspace can see
- rewrite the syscon EMAC clock register
driver_probe_device() also re-triggers deferred probing if
deferred_trigger_count changes during a probe:
drivers/base/dd.c:driver_probe_device() {
...
if (trigger_count != atomic_read(&deferred_trigger_count) &&
!defer_all_probes)
driver_deferred_probe_trigger();
...
}
If another device binds during any attempt, this starts another full
cycle. That can become the endless .probe() loop the documentation warns
about.
get_ephy_nodes() only uses priv->device->of_node and the sunxi_priv_data.
None of the mdio-mux lookup, of_clk_get() or
of_reset_control_get_exclusive() on the iphy node needs the MAC to be up.
The "mux must be registered after parent MDIO" comment only seems to
constrain sun8i_dwmac_register_mdio_mux().
Could the EPHY clock and reset lookup move into sun8i_dwmac_probe(),
before stmmac_pltfr_probe()?
The commit message uses the existing reset lookup deferral as precedent.
That path returns -EPROBE_DEFER from the same late point. Would moving the
lookup earlier fix both cases, instead of adding a second late deferral?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-b4-sun8i-emac-ephy-defer-v1-1-12a8591702fe%40gmail.com