Re: [PATCH] ksmbd: do not treat an unreadable security descriptor as none

From: Namjae Jeon

Date: Mon Nov 16 2026 - 09:02:30 EST


On Mon, Nov 16, 2026 at 9:48 PM Ian Bridges <icb@xxxxxxxxxxxx> wrote:
>
> On acl_xattr shares, a failed security descriptor load makes access
> checks fall back to POSIX permissions. An allocation or read failure
> can therefore bypass a stored deny ACE. Security queries also fall
> back, returning a descriptor built from the inode instead.
>
> Fail access checks and security queries on allocation and read errors.
> Keep the existing fallback for missing xattrs, unsupported xattrs, and
> malformed or stale descriptors.
>
> Propagate POSIX ACL read and allocation failures during descriptor
> validation too. Otherwise, hashing an unreadable ACL as absent can
> make a valid descriptor appear stale and allow the same fallback.
> Leave the descriptor store path's error handling unchanged.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Fixes: f44158485826 ("cifsd: add file operations")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ian Bridges <icb@xxxxxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks.