Re: [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver

From: Marco Giunta

Date: Mon Nov 16 2026 - 05:57:36 EST


Hi David,

just a quick comment that this:

> The key map follows ideapad-laptop. One code seen on the Yoga 9 2-in-1
> 16 (arm64) is new: 0x48 for the Smart Connect key.

isn't quite right; the ideapad-laptop driver has covered the smart connect
key/event 0x48 since commit ccc8c8481c1f ("platform/x86: ideapad-laptop:
Map Smart Connect hotkey to KEY_LINK_PHONE"), which is in 7.4-rc1+.

> + /* Smart Connect, phone to PC link */
> + { KE_KEY, 0x48, { KEY_PROG2 } },

Similarly to that commit, I would suggest using KEY_LINK_PHONE here
instead.

Best regards,
Marco