Re: [PATCH v2 1/4] leds: trigger: netdev: Put netdev on activate error path
From: Sverdlin, Alexander
Date: Mon Sep 28 2026 - 04:29:45 EST
Hi Andrew!
On Sun, 2026-09-27 at 17:02 +0200, Andrew Lunn wrote:
> On Mon, Sep 21, 2026 at 11:32:43AM +0200, A. Sverdlin wrote:
> > From: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>
> >
> > When hw control is active, set_device_name() takes a reference on the
> > netdev via dev_get_by_name(). The register_netdevice_notifier() failure
> > path frees trigger_data without dropping it, leaking the netdev.
>
> Maybe it would be better to add a unset_device_name(), which releases
> the reference, and does anything else which needs to be undone?
ACK
pw-bot: cr
--
Alexander Sverdlin
Siemens AG
www.siemens.com