RE: [PATCH v6 09/16] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF support

From: John Madieu

Date: Wed May 13 2026 - 11:56:39 EST


Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Mittwoch, 13. Mai 2026 11:42
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v6 09/16] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF
> support
>
> Hi John,
>
> On Tue, 12 May 2026 at 20:28, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > Add support for the SSIU found on the Renesas RZ/G3E SoC, which
> > provides a different BUSIF layout compared to earlier generations:
> >
> > - SSI0-SSI4: 4 BUSIF instances each (BUSIF0-3)
> > - SSI5-SSI8: 1 BUSIF instance each (BUSIF0 only)
> > - SSI9: 4 BUSIF instances (BUSIF0-3)
> > - Total: 28 BUSIFs
> >
> > RZ/G3E also differs from Gen2/Gen3 implementations in that only two
> > pairs of BUSIF error-status registers are available instead of four,
> > and the SSI always operates in BUSIF mode with no PIO fallback.
> >
> > Rather than scattering SoC-specific checks across functional code,
> > introduce an extra capability flags in the match data:
> >
> > - RSND_SSIU_BUSIF_STATUS_COUNT_2: only two BUSIF error-status
> > register pairs are present. Used in rsnd_ssiu_busif_err_irq_ctrl()
> > and rsnd_ssiu_busif_err_status_clear() to limit register iteration.
> >
> > Future SoCs sharing these constraints can set the flags without
> > requiring code changes.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/sound/soc/renesas/rcar/core.c
> > +++ b/sound/soc/renesas/rcar/core.c
> > @@ -107,7 +107,8 @@ static const struct of_device_id rsnd_of_match[] = {
> > { .compatible = "renesas,rcar_sound-gen4", .data = (void
> *)RSND_GEN4 },
> > /* Special Handling */
> > { .compatible = "renesas,rcar_sound-r8a77990", .data = (void
> *)(RSND_GEN3 | RSND_SOC_E) },
> > - { .compatible = "renesas,r9a09g047-sound", .data = (void
> *)(RSND_RZ3 | RSND_RZG3E) },
> > + { .compatible = "renesas,r9a09g047-sound", .data = (void
> *)(RSND_RZ3 | RSND_RZG3E |
> > +
> > + RSND_SSIU_BUSIF_STATUS_COUNT_2) },
>
> Nit: please split the line after the comma instead of after the pipe
> character.

Noted. Will take care of it in v7.

Regards,
John