Re: [PATCH] staging: greybus: documentation: replace strncpy() with strscpy_pad()

From: Dan Carpenter

Date: Tue Oct 14 2025 - 09:53:08 EST


On Tue, Oct 14, 2025 at 01:41:48PM +0000, Vivek BalachandharTN wrote:
> strncpy() does not guarantee NUL-termination and is deprecated for
> NUL-terminated strings. Replace it with strscpy_pad(), which guarantees
> NUL-termination and zero-pads the remaining bytes, matching the fixed-size
> firmware tag semantics.
>
> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@xxxxxxxxx>
> ---
> .../greybus/Documentation/firmware/firmware.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/greybus/Documentation/firmware/firmware.c b/drivers/staging/greybus/Documentation/firmware/firmware.c
> index 3b35ef6d4adb..deac8584841b 100644
> --- a/drivers/staging/greybus/Documentation/firmware/firmware.c
> +++ b/drivers/staging/greybus/Documentation/firmware/firmware.c

This is sample user space code so the strscpy_pad() isn't available. It
will break the compile.

regards,
dan carpenter