Re: [PATCH v4 4/6] iio: accel: bma400: Replace bit shifts with FIELD_PREP and FIELD_GET
From: Jonathan Cameron
Date: Sun Oct 12 2025 - 11:54:23 EST
On Tue, 7 Oct 2025 11:25:04 +0530
Akshay Jindal <akshayaj.lkd@xxxxxxxxx> wrote:
> set_* functions involve left shift of param values into respective
> register fields before writing to register. Similarly get_* functions
> involve right shift to extract values from the respective bit fields.
> Replace these explicit shifting statements with standard kernel style
> macros FIELD_GET and FIELD_PREP.
Trivial but FIELD_GET() and FIELD_PREP() in patch descriptions (And title).
That helps show they take parameters and are function like.
>
> Signed-off-by: Akshay Jindal <akshayaj.lkd@xxxxxxxxx>
Code looks good to me
Jonathan