Re: [PATCH] HID: multitouch: add IGNORE_DUPLICATES quirk for ELAN1206 (04f3:30f1)

[Jiri Kosina]

On Sun, 5 Oct 2025, Matt Roberts wrote:

> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 2879e65cf..ed318c80e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2150,6 +2150,10 @@ static const struct hid_device_id mt_devices[] = {
>                 HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>                         USB_VENDOR_ID_ELAN, 0x32ae) },
> 
> +        /* ELAN1206 touchpad: duplicate tracking IDs cause hold/click storms */
> +        { .driver_data = MT_QUIRK_IGNORE_DUPLICATES,
> +          HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH, 0x04f3, 0x30f1) },

Is there a reason not to use USB_VENDOR_ID_ELAN here, instead of 
open-coding 0x04f3?

Also, the patch has been whitespace-corrupted, so it can't be applied. 
Could you please look into fixing that, and resubmit?

Thanks!

-- 
Jiri Kosina
SUSE Labs