Re: [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()

[Dan Carpenter]

On Tue, Sep 02, 2025 at 04:42:41PM +0800, Andy Yan wrote:
> 
> Hello Dan,
> 
> At 2025-09-02 14:33:44, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> wrote:
> >This dw_dp_video_need_vsc_sdp() function is type bool so returning
> >-EINVAL means returning true.  Return false instead.
> >
> >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
> >Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> 
> Reviewed-by: Andy Yan <andyshrk@xxxxxxx>
> 

Ping?

regards,
dan carpenter

> 
> >---
> > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >index 9bbfe8da3de0..33be4eae2b20 100644
> >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> > 
> > 	state = dw_dp_get_bridge_state(dp);
> > 	if (!state)
> >-		return -EINVAL;
> >+		return false;
> > 
> > 	if (!link->vsc_sdp_supported)
> > 		return false;
> >-- 
> >2.47.2