Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.

[Andrew Lunn]

> +				interrupt-names = "rx", "emac_ptp_tx",
> +								"hsr_ptp_tx";

Something looks wrong with the indentation here. The same happens in
at least one other place.

> +&pruss2_mdio {
> +	status = "okay";
> +	pruss2_eth0_phy: ethernet-phy@0 {
> +		reg = <0>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
> +	};
> +
> +	pruss2_eth1_phy: ethernet-phy@1 {
> +		reg = <1>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> +	};


PHY interrupts are 99% level, not edge, because they represent an
interrupt controller in the PHY, and you need to clear all the
interrupts in the controller before it deasserts the interrupt pin.

    Andrew

---
pw-bot: cr