Re: [PATCH v4] hugetlbfs: check for shareable lock before calling huge_pmd_unshare()

From: Oscar Salvador

Date: Mon Oct 13 2025 - 09:12:38 EST


On Mon, Oct 13, 2025 at 11:54:00AM +0200, David Hildenbrand wrote:
> On 13.10.25 11:33, Deepanshu Kartikey wrote:
> > Hi David,
> >
> > That makes a lot of sense - moving the assertions after the early return
> > checks is cleaner since the locks are only needed when actual unsharing
> > work happens.
> >
> > Should I send a v5 with your suggested change?
>
> Let's wait if the hugetlb maintainers have any preference.

Yes, now that I look again I think your suggestion makes more sense and
its much cleaner :-)



--
Oscar Salvador
SUSE Labs