Re: [PATCH v1] arm: mach-orion5x: ts78xx: simplify support configuration with table

From: Andrew Lunn

Date: Mon Oct 13 2025 - 08:14:39 EST


On Sun, Oct 12, 2025 at 04:51:47PM -0700, Alex Tran wrote:
> Replace switch statement based configuration with a lookup table approach.
> The table is iterated through matching the correct configuration instead of
> setting the configuration on a case by case basis.

Is there anything actually wrong with the current code?

How did you test this? Do you have a tx78xx?

The only changes made to this file in the last decade have been tree
wide changes. So unless you have one of these machines and intend to
add new features, i suggest you just leave this alone, it is just
needles churn to an ancient platform.

Andrew