Re: [PATCH v3 0/3] add sysfs nodes to configure TPDA's registers

[Jie Gan]

On 9/15/2025 10:12 AM, Jie Gan wrote:
> On 8/27/2025 7:59 PM, James Clark wrote:
> > On 27/08/2025 11:55 am, Jie Gan wrote:
> > > Patchset 1 introduces configuration of the cross-trigger registers with
> > > appropriate values to enable proper generation of cross-trigger packets.
> > >
> > > Patchset 2 introduces a logic to configure the TPDA_SYNCR register,
> > > which determines the frequency of ASYNC packet generation. These packets
> > > assist userspace tools in accurately identifying each valid packet.
> > >
> > > Patchset 3 introduces a sysfs node to initiate a flush request for the
> > > specific port, forcing the data to synchronize and be transmitted to the
> > > sink device.
> > >
> > > Changes in V3:
> > > 1. Optimizing codes according to James's comment.
> > > Link to V2 - https://lore.kernel.org/all/20250827042042.6786-1- 
> > > jie.gan@xxxxxxxxxxxxxxxx/
> > >
> > > Changes in V2:
> > > 1. Refactoring the code based on James's comment for optimization.
> > > Link to V1 - https://lore.kernel.org/all/20250826070150.5603-1- 
> > > jie.gan@xxxxxxxxxxxxxxxx/
> > >
> > > Tao Zhang (3):
> > >    coresight: tpda: add sysfs nodes for tpda cross-trigger configuration
> > >    coresight: tpda: add logic to configure TPDA_SYNCR register
> > >    coresight: tpda: add sysfs node to flush specific port
> > >
> > >   .../testing/sysfs-bus-coresight-devices-tpda  |  50 ++++
> > >   drivers/hwtracing/coresight/coresight-tpda.c  | 278 ++++++++++++++++++
> > >   drivers/hwtracing/coresight/coresight-tpda.h  |  33 ++-
> > >   3 files changed, 360 insertions(+), 1 deletion(-)
> > >   create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight- 
> > > devices-tpda
> >
> > Reviewed-by: James Clark <james.clark@xxxxxxxxxx>
>
> Gentle ping.

Hi Suzuki,

James has reviewed the patch series. May I know whether you have any 
comments about the patch series before get applied?

Thanks,
Jie

>