RE: [外部邮件] Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks

[Li,Rongqing]

> …
> > This patch extends the …
> 
> Will another imperative wording approach become more helpful for an
> improved change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docum
> entation/process/submitting-patches.rst?h=v6.17#n94
> 

will fix in next version
> 
> …
> > +++ b/kernel/hung_task.c
> …
> @@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t,
> unsigned long timeout) …
> >  	trace_sched_process_hang(t);
> >
> > -	if (sysctl_hung_task_panic) {
> > +	if (sysctl_hung_task_panic &&
> > +			(total_hung_task >= sysctl_hung_task_panic)) {
> …
> 
> I suggest to use the following source code variant instead.
> 
> 	if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic)
> {
> 

will fix in next version

thanks

-Li

> 
> Regards,
> Markus