Re: [PATCH] iio: adc: ad7280a: fix ad7280_store_balance_timer()

[Nuno Sá]

On Fri, 2025-10-10 at 10:44 -0500, David Lechner wrote:
> Use correct argument to iio_str_to_fixpoint() to parse 3 decimal places.
> 
> iio_str_to_fixpoint() has a bit of an unintuitive API where the
> fract_mult parameter is the multiplier of the first decimal place as if
> it was already an integer.  So to get 3 decimal places, fract_mult must
> be 100 rather than 1000.
> 
> Fixes: 96ccdbc07a74 ("staging:iio:adc:ad7280a: Standardize extended ABI naming")
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/iio/adc/ad7280a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c
> index
> dda2986ccda075fbfa04851a1ceac7a186b47537..50a6ff7c8b1c73905fabdef119d41204c32b590c
> 100644
> --- a/drivers/iio/adc/ad7280a.c
> +++ b/drivers/iio/adc/ad7280a.c
> @@ -541,7 +541,7 @@ static ssize_t ad7280_store_balance_timer(struct iio_dev
> *indio_dev,
>  	int val, val2;
>  	int ret;
>  
> -	ret = iio_str_to_fixpoint(buf, 1000, &val, &val2);
> +	ret = iio_str_to_fixpoint(buf, 100, &val, &val2);
>  	if (ret)
>  		return ret;
>  
> 
> ---
> base-commit: a9682f53c2d1678b93a123cdaa260e955430bc5c
> change-id: 20251010-iio-adc-ad7280a-fix-ad7280_store_balance_timer-126bc5b4ee90
> 
> Best regards,