Re: [PATCH v2] memory: renesas-rpc-if: Add suspend/resume support

[Krzysztof Kozlowski]

On 23/09/2025 17:14, Biju wrote:
>  	if (rpc->info->type == XSPI_RZ_G3E) {
> -		struct clk *spi_clk;
> -
> -		spi_clk = devm_clk_get_enabled(dev, "spix2");
> -		if (IS_ERR(spi_clk))
> -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> +		rpc->spix2_clk = devm_clk_get_enabled(dev, "spix2");
> +		if (IS_ERR(rpc->spix2_clk))
> +			return dev_err_probe(dev, PTR_ERR(rpc->spix2_clk),
>  					     "cannot get enabled spix2 clk\n");
>  
> -		spi_clk = devm_clk_get_enabled(dev, "spi");
> -		if (IS_ERR(spi_clk))
> -			return dev_err_probe(dev, PTR_ERR(spi_clk),
> +		rpc->spi_clk = devm_clk_get_enabled(dev, "spi");
> +		if (IS_ERR(rpc->spi_clk))
> +			return dev_err_probe(dev, PTR_ERR(rpc->spi_clk),
>  					     "cannot get enabled spi clk\n");
>  	}
>  
> @@ -1063,6 +1063,44 @@ static void rpcif_remove(struct platform_device *pdev)
>  	platform_device_unregister(rpc->vdev);
>  }
>  
> +static int rpcif_suspend(struct device *dev)
> +{
> +	struct rpcif_priv *rpc = dev_get_drvdata(dev);
> +
> +	if (rpc->info->type == XSPI_RZ_G3E) {

clk are null in other case, so you can simplify it by dropping this if().

> +		clk_disable_unprepare(rpc->spi_clk);
> +		clk_disable_unprepare(rpc->spix2_clk);
> +	}
> +
> +	return 0;
> +}
> +
> +static int rpcif_resume(struct device *dev)
> +{
> +	struct rpcif_priv *rpc = dev_get_drvdata(dev);
> +
> +	if (rpc->info->type == XSPI_RZ_G3E) {


... which would save you one indentation here making it a bit more readable.

> +		int ret;
> +
> +		ret = clk_prepare_enable(rpc->spix2_clk);
> +		if (ret) {
> +			dev_err(dev, "failed to enable spix2 clock: %pe\n",
> +				ERR_PTR(ret));
> +			return ret;


Best regards,
Krzysztof