Re: [PATCH] wifi: wcn36xx: Remove unused wcn36xx_smd_update_scan_params

From: Jeff Johnson
Date: Thu Oct 09 2025 - 20:09:01 EST


On 10/9/2025 3:15 PM, Loic Poulain wrote:
> Hi Jeff,
>
> On Thu, Oct 9, 2025 at 5:25 PM Dr. David Alan Gilbert <linux@xxxxxxxxxxx> wrote:
>>
>> * Loic Poulain (loic.poulain@xxxxxxxxxxxxxxxx) wrote:
>>> On Thu, Jun 19, 2025 at 3:05 AM <linux@xxxxxxxxxxx> wrote:
>>>>
>>>> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>>>>
>>>> wcn36xx_smd_update_scan_params() last use was removed in 2020 by
>>>> commit 5973a2947430 ("wcn36xx: Fix software-driven scan")
>>>>
>>>> Remove it.
>>>>
>>>> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>>>
>>> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
>>
>> Hi Loic,
>> Is this getting into a pull somewhere?
>
> Can it be picked for ath10-next?

This was not on my radar since it wasn't sent to linux-wireless and hence
isn't tracked in patchwork. I just looked at it and it seems the following are
now also unused and could be removed:
struct wcn36xx_hal_update_scan_params_resp
struct wcn36xx_hal_update_scan_params_req_ex

Let me know if you want me to take this as-is or wait for a v2. If you send a
v2 please also include linux-wireless so that it is tracked by patchwork.

/jeff