Re: [PATCH v2] gpio: pisosr: read ngpios as U32

From: Bartosz Golaszewski
Date: Thu Oct 09 2025 - 06:07:25 EST


On Wed, Oct 8, 2025 at 11:28 PM Stefano Manni <stefano.manni@xxxxxxxxx> wrote:
>
>
>
> On lun, ago 11 2025 at 09:56:51 +02:00:00, Bartosz Golaszewski
> <brgl@xxxxxxxx> wrote:
> > On Wed, Aug 6, 2025 at 9:17 AM Stefano Manni
> > <stefano.manni@xxxxxxxxx> wrote:
> >>
> >> If of_property_read_u16() is used instead the value read
> >> is always zero.
> >>
> >
> > Please state more clearly what the problem is. This sentence is quite
> > garbled,
>
>
> the value returned by of_property_read_u16() is always zero, if
> of_property_read_u32()
> is used instead , then the returned value is the right one contained in
> the dts.
>

So please put this into the commit message.

> >
> > If you're touching this, can you switch to using generic device
> > properties instead?
> >
>
> what do you mean with "generic device properties"?
>

Functions that allow to read properties through the fwnode associated
with a device bound to a driver. In this case:
device_property_read_u32().

Bart