Re: [PATCH] i2c: designware-platdrv: handle reset control deassert error

From: Mika Westerberg
Date: Thu Oct 09 2025 - 05:30:37 EST


Hi,

On Thu, Oct 09, 2025 at 11:37:03AM +0300, Artem Shimko wrote:
> Handle the error returned by reset_control_deassert() in the probe
> function to prevent continuing probe when reset deassertion fails.
>
> Previously, reset_control_deassert() was called without checking its
> return value, which could lead to probe continuing even when the
> device reset wasn't properly deasserted.
>
> The fix checks the return value and returns an error with dev_err_probe()
> if reset deassertion fails, providing better error handling and
> diagnostics.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@xxxxxxxxx>

Looks good to me,

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>