Re: [PATCH] smb: client: Move an error code assignment in smb3_init_transform_rq()
From: Markus Elfring
Date: Wed Oct 08 2025 - 17:00:49 EST
> Also when a patch doesn't shrink code, but even grows it by one line, and doesn't make it much clearer, it is probably not worth changing (it complicates future backports of real fixes in the future eg). Let's limit these to those that shrink code and make code clearer (or ideally fix potential bugs)
Do you insist to keep an extra initialisation for the local variable “rc”
despite of the implementation detail that the value “-ENOMEM” is needed
only for a single if branch here?
Regards,
Markus