Re: [PATCH] can: treewide: remove can_change_mtu()

[Marc Kleine-Budde]

On 03.10.2025 12:16:38, Vincent Mailhol wrote:
> can_change_mtu() became obsolete by commit 23049938605b ("can:
> populate the minimum and maximum MTU values"). Now that
> net_device->min_mtu and net_device->max_mtu are populated, all the
> checks are already done by dev_validate_mtu() in net/core/dev.c.
> 
> Remove the net_device_ops->ndo_change_mtu() callback of all the
> physical interfaces, then remove can_change_mtu(). Only keep the
> vcan_change_mtu() and vxcan_change_mtu() because the virtual
> interfaces use their own different MTU logic.
> 
> The only functional change this patch introduces is that now the user
> will be able to change the MTU even if the interface is up. This does
> not matter for Classical CAN and CAN FD because their MTU range is
> composed of only one value, respectively CAN_MTU and CANFD_MTU. For
> the upcoming CAN XL, the MTU will be configurable within the
> CANXL_MIN_MTU to CANXL_MAX_MTU range at any time, even if the
> interface is up. This is consistent with the other net protocols and
> does not contradict ISO 11898-1:2024 as having a modifiable MTU is a
> kernel extension.
> 
> Signed-off-by: Vincent Mailhol <mailhol@xxxxxxxxxx>

Applied to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature