Re: [PATCH 00/17] USB/IP VHCI driver cleanup
From: Cristian Ciocaltea
Date: Wed Oct 08 2025 - 13:01:09 EST
On 10/8/25 2:00 PM, Greg Kroah-Hartman wrote:
> On Wed, Sep 24, 2025 at 02:44:07PM -0600, Shuah Khan wrote:
>> On 9/2/25 05:56, Cristian Ciocaltea wrote:
>>> These patches were initially part of the USB/IP VHCI suspend fix series
>>> [1] to address a bunch of coding style issues and make checkpatch happy
>>> for the entire driver.
>>>
>>> As suggested by Greg, I'm sending this as a separate patch set now.
>>>
>>> [1] https://lore.kernel.org/r/20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@xxxxxxxxxxxxx
>>>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
>>> ---
>>> Cristian Ciocaltea (17):
>>> usb: vhci-hcd: Ensure lines do not end with '('
>>> usb: vhci-hcd: Consistently use the braces
>>> usb: vhci-hcd: Avoid unnecessary use of braces
>>> usb: vhci-hcd: Consistently use blank lines
>>> usb: vhci-hcd: Drop spaces after casts
>>> usb: vhci-hcd: Add spaces around operators
>>> usb: vhci-hcd: Drop unnecessary parentheses
>>> usb: vhci-hcd: Fix open parenthesis alignment
>>> usb: vhci-hcd: Simplify NULL comparison
>>> usb: vhci-hcd: Simplify kzalloc usage
>>> usb: vhci-hcd: Use the paranthesized form of sizeof
>>> usb: vhci-hcd: Fix block comments
>>> usb: vhci-hcd: Remove ftrace-like logging
>>> usb: vhci-hcd: Consistently use __func__
>>> usb: vhci-hcd: Do not split quoted strings
>>
>>> usb: vhci-hcd: Switch to dev_err_probe() in probe path
>>> usb: vhci-hcd: Replace pr_*() with dev_*() logging
>>
>> I acked the 16/17 and 17/17 - others I don't see a reason for code
>> churn.
>
> Great! Christian, can you resend just those two patches as a series
> with Shuah's ack on them for me to pick up?
Sure, please see:
https://lore.kernel.org/all/20251008-vhci-hcd-cleanup-v2-0-b6acc4dd6e44@xxxxxxxxxxxxx/
Thanks,
Cristian