Re: [PATCH] x86/resctrl: Fix buggy overflow when reactivating previously Unavailable RMID

From: Dave Martin
Date: Wed Oct 08 2025 - 11:24:17 EST


Hi,

On Tue, Oct 07, 2025 at 01:23:36PM -0700, Reinette Chatre wrote:
> Hi Babu,
>
> Thank you for catching and preparing a fix for this issue.
>
> On 10/6/25 4:13 PM, Babu Moger wrote:
> > The issue was observed during testing on systems with multiple resctrl
> > domains, where tasks were dynamically moved between domains.
>
> (please let changelog stand on its own and not be a continuation of subject line)

[...]

[Quick, drive-by observation:]

Can I add that the commit message also seems way too long?

I think some of the description of the problem symptom could probably
be after the tearoff -- there doesn't seem to be a clear statement of
what is actually wrong in the code, or of why the change made in the
patch fixes it (or if there is, I struggled to find it.)

I puzzled over this for some minutes before I figured out this patch is
fixing something that is not upstream, yet. A statement to that effect
would have helped.

Possibly I didn't read carefully enough...

Cheers
---Dave