Re: [PATCH net-next v13 4/5] net: ti: prueth: Adds link detection, RX and TX support.

[Jakub Kicinski]

On Tue, 12 Aug 2025 19:04:19 +0530 Parvathi Pudi wrote:
> +static irqreturn_t icssm_emac_rx_packets(struct prueth_emac *emac, int quota)

Please stick to calling the budget budget rather than synonym terms
like "quota". Makes it harder to review the code.

> +	/* search host queues for packets */
> +	for (i = start_queue; i <= end_queue; i++) {
> +		queue_desc = emac->rx_queue_descs + i;
> +		rxqueue = &queue_infos[PRUETH_PORT_HOST][i];

budget can be 0, in which case the driver is not supposed to process
Rx, just Tx (if the NAPI instance is used to serve completions).

> +	num_rx_packets = icssm_emac_rx_packets(emac, budget);
> +	if (num_rx_packets < budget) {
> +		napi_complete_done(napi, num_rx_packets);

don't ignore the return value of napi_complete_done()
-- 
pw-bot: cr