Re: [PATCH net-next 2/2] net: phy: mxl-86110: add basic support for MxL86111 PHY

[Daniel Golle]

On Fri, Aug 15, 2025 at 07:34:05PM +0200, Andrew Lunn wrote:
> > +	/* For fiber forced mode, power down/up to re-aneg */
> > +	if (modes != LINK_INBAND_DISABLE) {
> > +		__phy_modify(phydev, MII_BMCR, 0, BMCR_PDOWN);
> > +		usleep_range(1000, 1050);
> > +		__phy_modify(phydev, MII_BMCR, BMCR_PDOWN, 0);
> > +	}
> 
> Is a full power down required? To restart autoneg all you normally
> need to do it set BMCR_ANRESTART. See genphy_restart_aneg().

According to the vendor driver a full power down is required when
enabling in-band-an on the SerDes interface. BMCR_ANRESTART only
affects the UTP interface apparently.

> 
> > @@ -648,8 +928,24 @@ static struct phy_driver mxl_phy_drvs[] = {
> >  		.set_wol		= mxl86110_set_wol,
> >  		.led_brightness_set	= mxl86110_led_brightness_set,
> >  		.led_hw_is_supported	= mxl86110_led_hw_is_supported,
> > -		.led_hw_control_get     = mxl86110_led_hw_control_get,
> > -		.led_hw_control_set     = mxl86110_led_hw_control_set,
> > +		.led_hw_control_get	= mxl86110_led_hw_control_get,
> > +		.led_hw_control_set	= mxl86110_led_hw_control_set,
> 
> That should really be in a different patch.

Ok, I will break it out into a patch prepending the other two.